Poetry: let datasource set default registry when possible.

renovatebot · Sep 21, 2019 · 0256ad0 · 0256ad0
1 parent 93c072d
commit 0256ad0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 21 deletions.
diff --git a/lib/manager/poetry/extract.ts b/lib/manager/poetry/extract.ts
@@ -88,17 +88,17 @@ function extractFromSection(
 
 function extractRegistries(pyprojectfile: PoetryFile): string[] {
   const sources = pyprojectfile.tool.poetry.source;
-  const registryUrls: string[] = ['https://pypi.org/pypi/'];
 
-  if (!Array.isArray(sources)) {
-    return registryUrls;
+  if (!Array.isArray(sources) || sources.length === 0) {
+    return [];
   }
 
+  const registryUrls: string[] = [];
   for (const source of sources) {
     if (source.url) {
       registryUrls.push(source.url);
     }
   }
 
-  return registryUrls;
+  return [...registryUrls, 'https://pypi.org/pypi/'];
 }
diff --git a/test/manager/poetry/__snapshots__/extract.spec.ts.snap b/test/manager/poetry/__snapshots__/extract.spec.ts.snap
@@ -1,17 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`lib/manager/poetry/extract extractPackageFile() can parse empty registries 1`] = `
-Array [
-  "https://pypi.org/pypi/",
-]
-`;
-
-exports[`lib/manager/poetry/extract extractPackageFile() can parse missing registries 1`] = `
-Array [
-  "https://pypi.org/pypi/",
-]
-`;
-
 exports[`lib/manager/poetry/extract extractPackageFile() extracts multiple dependencies (with dep = {version = "1.2.3"} case) 1`] = `
 Array [
   Object {
@@ -171,9 +159,9 @@ Array [
 
 exports[`lib/manager/poetry/extract extractPackageFile() extracts registries 1`] = `
 Array [
-  "https://pypi.org/pypi/",
   "https://foo.bar/simple/",
   "https://bar.baz/+simple/",
+  "https://pypi.org/pypi/",
 ]
 `;
 

diff --git a/test/manager/poetry/extract.spec.ts b/test/manager/poetry/extract.spec.ts
@@ -74,13 +74,11 @@ describe('lib/manager/poetry/extract', () => {
     });
     it('can parse empty registries', () => {
       const res = extractPackageFile(pyproject7toml, config);
-      expect(res.registryUrls).toMatchSnapshot();
-      expect(res.registryUrls).toHaveLength(1);
+      expect(res.registryUrls).toEqual([]);
     });
     it('can parse missing registries', () => {
       const res = extractPackageFile(pyproject1toml, config);
-      expect(res.registryUrls).toMatchSnapshot();
-      expect(res.registryUrls).toHaveLength(1);
+      expect(res.registryUrls).toEqual([]);
     });
     it('skips git dependencies', () => {
       const content =