-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager): Support poetry custom repositories. #4524
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7b81ece
feat(manager): Support poetry custom repositories.
gilbsgilbs 324301a
Poetry: add tests for empty and missing registries.
gilbsgilbs 93c072d
Poetry: keep querying pypi.org even if we find other registries.
gilbsgilbs 0256ad0
Poetry: let datasource set default registry when possible.
gilbsgilbs 817157e
Poetry: Put pypi index first.
gilbsgilbs 9de3f2b
Poetry: safely get source section from pyproject file.
gilbsgilbs 3d0db58
Poetry: return `null` instead of empty array when source section is e…
gilbsgilbs a3a36c2
Poetry: prettify.
gilbsgilbs f8f47e6
Poetry: fix tests.
gilbsgilbs dd7892d
Merge branch 'master' into poetry-reprositories
gilbsgilbs 14452cf
Poetry: deduplicate registry urls.
gilbsgilbs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
[tool.poetry] | ||
name = "example 6" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["John Doe <[email protected]>"] | ||
|
||
[tool.poetry.dependencies] | ||
dep0 = "0.0.0" | ||
|
||
[[tool.poetry.source]] | ||
name = "foo" | ||
url = "https://foo.bar/simple/" | ||
|
||
[[tool.poetry.source]] | ||
name = "bar" | ||
url = "https://bar.baz/+simple/" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
[tool.poetry] | ||
name = "example 7" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["John Doe <[email protected]>"] | ||
source = [] | ||
|
||
[tool.poetry.dependencies] | ||
dep0 = "0.0.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we de-dupe this in case the user configures pypi.org explicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I misread this comment as a statement instead of a question. I committed code that dedupes, but I don't think it is necessary as pypi datasource will only append pypi.org if registryUrls is empty. If poetry manager adds pypi.org itself, pypi datasource won't add any other datasource. Let me revert this.
Edit: unless you meant “configures pypi.org explicitly” in
pyproject.toml
, which I think is a bit silly 🤔 . Anyways, it is not a bad thing to dedup I think. Let's not revert after all.