feat(manager): Support poetry custom repositories. #4524
Conversation
lib/manager/poetry/extract.ts
Outdated
| @@ -88,12 +88,12 @@ function extractFromSection( | |||
|
|
|||
| function extractRegistries(pyprojectfile: PoetryFile): string[] { | |||
| const sources = pyprojectfile.tool.poetry.source; | |||
| const registryUrls: string[] = ['https://pypi.org/pypi/']; | |||
There was a problem hiding this comment.
Actually we prefer to handle defaults within datasource, not manager. Otherwise it's too hard to override the default registry URL in Renovate config.
There was a problem hiding this comment.
Do you think 0256ad0 is enough? Unless I'm missing something, I don't think I can easily use the default registry from the pypi datasource if I have other registries to add. Hence, I've done something similar to what pip_requirements manager does.
Co-Authored-By: Rhys Arkins <[email protected]>
…mpty. Co-Authored-By: Rhys Arkins <[email protected]>
gilbsgilbs
force-pushed
the
poetry-reprositories
branch
from
d95be0c to
f8f47e6
Compare
lib/manager/poetry/extract.ts
Outdated
| const registryUrls: string[] = ['https://pypi.org/pypi/']; | ||
| for (const source of sources) { | ||
| if (source.url) { | ||
| registryUrls.push(source.url); |
There was a problem hiding this comment.
Should we de-dupe this in case the user configures pypi.org explicitly?
There was a problem hiding this comment.
Sorry, I misread this comment as a statement instead of a question. I committed code that dedupes, but I don't think it is necessary as pypi datasource will only append pypi.org if registryUrls is empty. If poetry manager adds pypi.org itself, pypi datasource won't add any other datasource. Let me revert this.
Edit: unless you meant “configures pypi.org explicitly” in pyproject.toml, which I think is a bit silly 🤔 . Anyways, it is not a bad thing to dedup I think. Let's not revert after all.
|
Thanks @gilbsgilbs ! |
|
🎉 This PR is included in version 19.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See https://poetry.eustace.io/docs/repositories/#install-dependencies-from-a-private-repository
Closes #4523