-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 2 more nesting levels for toc #2189
base: main
Are you sure you want to change the base?
Conversation
I've thought about this for a while. Visually, I'd prefer sliders over radio buttons, but radio buttons are functional. I don't have any functional feedback. |
@NGPixel This PR has been open for a month. When can this PR be implemented? |
@NGPixel When can this PR be implemented? I need this feature because my documents have so many directories. Thank you, if possible |
It will be implemented in 3.0 update, which will include proper theming handling. I didn't want to merge something, including API changes, that would change in the following version. |
@NGPixel What ia the rough ETA on version 3? |
Q4 2020 |
Is this still scheduled for 3.0 @NGPixel? |
@NGPixel this feature seams to work quite well. What can I do to help get this into a release and maybe other PRs aswell? |
I would consider accepting this PR for 2.x as the next version still require more time. I would however want some UI changes as to not rely on 10 radio boxes, which is a bit too busy. A range slider would be more appropriate, example in 3.0: Also, the behavior should be more in line with how 3.x will work, with a
These changes shouldn't require much work but it would make the transition to 3.x much easier. |
If the OP doesn't react before I am done I will try to accomplish this and Push it here. And if I can help you with anything on version 3.0 let me know. btw: the current dev guideline for Mac seems broken. If I start the container, it always breaks at make because cmake is not present. I get 3 containers but the wiki never starts, just adminer is accessible. Not sure if I have done anything wrong though. |
I created a PR with Sliders instead feel free to have a look at #5101 |
fix: #1216
feature request: https://requarks.canny.io/wiki/p/allow-to-select-toc-depth-level (20 votes)
feature discussion at: #1931
To sum up the feature:
Check out the gif below for a quick overview.
@NGPixel and @fireundubh I would love to get any comments on the UI/UX as it is not my strong suite.