-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable ToC Heading Levels #5101
Conversation
test Revert "test" This reverts commit f4959c777a013d2c7966e6cc5b67ee29a067e417. Revert "First parts of reworking ToC Slider" This reverts commit 08cb4bd269a628f71f935e812b3980322a9d7303. Range Slider instead of radio button range slider in admin-theme
@NGPixel Any Feedback on this? |
Thanks for this PR! Some points to address:
Slider Range Values:
Here's a quick mockup of what it should look like: When Use Site Defaults is enabled (default): When Use Site Defaults is disabled: |
Collapse level is now controlled by upper limit of toc level range slider everything beneath is collapsed
@NGPixel I will add the Use Site Default Toggle. |
Use Site Default Switch now changes between usage of page specific toc levels and site specific toc levels per site. Removed Global selection from range slider of toc level therefor
@NGPixel Toggle Switch is now implemented and working as I would expect it. Please feel free to check that for yourself. |
In your screenshots, everything looks great, with the exception of the collapse defaults. If the right end of the slider is set to H2, then H2 should be visible but any children (H3, H4, H5 and H6) should be collapsed and not visible by default (they can still be expanded by the user though). |
Then everything is as you expect it. The upper one is expanded by hand to show how it works. The arrows are blue instead of black after clicking on it and show upwards instead of downwards. The lower part of the ToC is the normal not clicked version. That's why I added two of them, to be able to showcase both at the same time. |
Co-authored-by: Regev Brody <[email protected]>
Co-authored-by: Regev Brody <[email protected]>
@NGPixel Why is this only in the feat-toc branch? Because nowadays this one is much behind the main branch. Could this also be pushed to the main branch? |
@FlorinBuffet, agreed. Why was this merged into a 'stale' branch? |
@cyr0nk0r Because it's not ready for production use. It has many display bugs that need to be resolved first. |
perfect is the enemy of good. I think the people that want this (myself included) would rather deal with a few display bugs and have something for the last 18 months than nothing at all. It's going to get revamped and be fixed anyway in 3.0. |
Hej @NGPixel if you have a short mention of the display bugs that need to be resolved I could try that and make a new MR if that helps anything |
Hi @NGPixel is there any update on this? It looks like @TimoKruth is interested in helping to resolve any display bugs. This feature would be quite helpful for my use case. |
@NGPixel as you wrote
I added a range slider as config choice for ToC heading selection. Please review and give your opinion.
Yeah and I have no idea how to put this in the original PR. Sorry for that.
Maybe we should make the collapse Level a dropdown menu?
The look of my work:
Page option:
Admin option