Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonschemas: add 2 new document types #887

Merged
merged 2 commits into from
Aug 25, 2022
Merged

jsonschemas: add 2 new document types #887

merged 2 commits into from
Aug 25, 2022

Conversation

PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Aug 18, 2022 •
edited
Loading

Co-Authored-by: Pascal Repond [email protected]

@PascalRepond PascalRepond force-pushed the rep-doctype branch 2 times, most recently from 9e58bd9 to a0a3e96 Compare August 22, 2022 10:45
pronguen
pronguen suggested changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@pronguen pronguen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 problems regarding #881

sonar/modules/deposits/jsonschemas/deposits/deposit-v1.0.0_src.json Outdated Show resolved Hide resolved
sonar/modules/documents/serializers/schemas/schemaorg.py Outdated Show resolved Hide resolved
@PascalRepond
jsonschemas: add 2 new document types
6b9de3d 
* Adds conference object and book review document types for documents
and deposits.
* Changes value and label for document_type_other for better clarity.
* Initializes alembic.
* Includes alembic script for db migration.
* Closes rero#881.

Co-Authored-by: Pascal Repond <[email protected]>
@pronguen
Copy link
Contributor

pronguen commented Aug 25, 2022 •
edited by PascalRepond
Loading

Problems regarding #626

  • Field numberingVolume (document) and volume (deposit) still not available for the specified document types
    image
  • [not blocking] We should be able to remove field partOf.document.contribution (document) but there are no trash icon... still this is possible to save the record with the empty field.
  • Problem 2 of the issue, with field partOf.document.contribution (document), is not solved. Actually, the value is not saved in the field, only in in partOf.text.

@PascalRepond
jsonschema: fix partOf subfields display
4333435 
* Closes rero#626.
* Makes the `status` deposit field required to prevent submitting
a deposit with no status from the API.

Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond merged commit 09050b7 into rero:staging Aug 25, 2022
@PascalRepond PascalRepond deleted the rep-doctype branch August 25, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronguen pronguen pronguen requested changes

@zannkukai zannkukai zannkukai approved these changes

@jma jma jma approved these changes

@rerowep rerowep Awaiting requested review from rerowep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 2 document types: conference object, book review Problems in the document editor within field partOf
4 participants
@PascalRepond @pronguen @jma @zannkukai