Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents api: fix missing contribution #889

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 25, 2022

  • Fixes missing contributions in the partOf field.
  • Updates wand package for apple M1.
  • Take into account .env file for the tests.

Co-Authored-by: Johnny Mariéthoz [email protected]

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@jma jma changed the title in progress documents api: fix missing contribution Aug 25, 2022
@jma jma marked this pull request as ready for review August 25, 2022 14:50
@jma jma requested review from PascalRepond and rerowep August 25, 2022 14:50
sonar/modules/documents/views.py Outdated Show resolved Hide resolved
sonar/modules/documents/views.py Outdated Show resolved Hide resolved
@jma jma requested a review from vgranata August 29, 2022 07:58
@PascalRepond PascalRepond force-pushed the maj-fix-partOf branch 3 times, most recently from 5a84a88 to 94ed9a1 Compare August 30, 2022 07:09
* Fixes missing contributions in the `partOf` field.
* Updates `wand` package for apple M1.
* Take into account `.env` file for the tests.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Pascal Repond <[email protected]>
@PascalRepond PascalRepond merged commit 6f38a33 into rero:staging Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants