Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DNA (getting started) example to C++ #3963

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Port DNA (getting started) example to C++ #3963

merged 8 commits into from
Oct 24, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 23, 2023 •
edited by github-actions bot
Loading

What

Also adds implicit conversion to underlying datatypes. Seems quite convenient, to be seen if this can get in the way.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@Wumpf Wumpf added 🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 23, 2023
@emilk emilk self-requested a review October 23, 2023 14:39
emilk
emilk approved these changes Oct 23, 2023
View reviewed changes
examples/cpp/dna/main.cpp Outdated Show resolved Hide resolved
examples/cpp/dna/README.md
@@ -0,0 +1,29 @@
---
title: Helix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not new in this PR, but it's a bit confusing that the example is called both dna and Helix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helix is the better name imho. DNA sounds like we're doing actual medical visualization

rerun_cpp/src/rerun/components/line_strip3d_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/demo_utils.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/demo_utils.cpp Outdated Show resolved Hide resolved
@Wumpf Wumpf force-pushed the andreas/cpp/dna-example branch from 2718c18 to 755ae7c Compare October 23, 2023 16:11
@Wumpf Wumpf mentioned this pull request Oct 23, 2023
Closed
4 tasks
@Wumpf
Copy link
Member Author

Wumpf commented Oct 24, 2023

known error on cargo deny.

@Wumpf Wumpf merged commit e02705e into main Oct 24, 2023
@Wumpf Wumpf deleted the andreas/cpp/dna-example branch October 24, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port "getting started" example code to C++
2 participants
@Wumpf @emilk