Nicer linestrip constructor #3967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🌊 C++ API
4 tasks
teh-cmc
approved these changes
Oct 24, 2023
|
Let's not merge until we decided whether #3971 is better |
Wumpf
added a commit
that referenced
this pull request
Oct 24, 2023
…be used to construct the inner component (#3971) ### What As an alternative (or in addition to) #3967 this introduces a pattern wherein any `ComponentBatch<C>` can be constructed from any `Vec<T>` where we have implemented an extension for constructing `C` from `T`. Additionally, this introduces a similar extension for constructing linestrips from vecs of Vec3-like things so that users don't event need to pick up a Vec3 dependency if they don't want to. These two combine to allow: ``` std::vector<std::vector<std::array<float, 3>>> points = { {{0.f, 0.f, 0.f}, {0.f, 0.f, 1.f}}, {{1.f, 0.f, 0.f}, {1.f, 0.f, 1.f}}, {{1.f, 1.f, 0.f}, {1.f, 1.f, 1.f}}, {{0.f, 1.f, 0.f}, {0.f, 1.f, 1.f}}, }; rec.log("segments", rerun::LineStrips3D(points)); ``` To do the correct thing. I think this is important, relative to the variadic / initializer-list approach since it's more likely to match the kind of patterns users will encounter in the real-world, where they want to build a Vec of Vecs without needing to instantiate rerun types directly. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/{{ pr.number }}) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }}) - [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Andreas Reich <[email protected]>
|
replaced by #3971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
LineStripsNDC++ constructors are unfriendly with multiple strips #3202Technically not the exact syntax asked for. But pretty pretty close :)
Checklist