Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto properties no longer being applied for legacy properties (EntityProperties) #6190

Merged
merged 3 commits into from
May 2, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 2, 2024

What

This regressed in #6164. Decided not to roll back things (which would have been hard) but instead reimplement how these properties are passed through and make their role more obvious.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🦟 regression A thing that used to work in an earlier release 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 2, 2024
@emilk emilk changed the title Fix auto properties no longer being applies for legacy properties (EntityProperties) Fix auto properties no longer being applied for legacy properties (EntityProperties) May 2, 2024
@teh-cmc teh-cmc force-pushed the andreas/fix-legacy-prop-regression branch from c66cd12 to d84d9af Compare May 2, 2024 11:01
@teh-cmc
Copy link
Member

teh-cmc commented May 2, 2024

This highlighted a mishandled edge-case introduced in #6157 caused by the use of TimeInt::MIN instead of TimeInt::STATIC.

Rebased on main and fixed the issue directly here.

@teh-cmc
Copy link
Member

teh-cmc commented May 2, 2024

Things now work as expected:
image

But I don't get why the UI says the Backproject meter prop is 1.0. Shouldn't that be 1000.0?

@Wumpf
Copy link
Member Author

Wumpf commented May 2, 2024

oh good catch. more bugs.

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Appreciate the rename since it makes it easier to delete this once the legacy props are gone.

@jleibs jleibs merged commit 0c14528 into main May 2, 2024
34 of 35 checks passed
@jleibs jleibs deleted the andreas/fix-legacy-prop-regression branch May 2, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heuristics for depth image size broken, causing arkit scenes to be unusable
3 participants