-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show first line of the docs when hovering a component name #6609
Conversation
Part of Haven't looked at anything yet, but this should also drag in the opt-in archetype field documentation we have via attribute ( ( |
|
1f407e2
to
70e9685
Compare
dynamic lookup via archetype name would be preferable anyways I think! The more we can pass |
70e9685
to
fb97613
Compare
fb97613
to
01e49f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not stack the crate hierarchy deeper when we don't have to!
As for name: re_types_registry
is quite at odds with component type registration in the store. I'd rather call it by what it does re_types_meta_info
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!!
(resolved merge conflicts) |
What
Now that we can override all kinds of components in the UI, we should also take care to explain them to the user.
Previously all the user had to go on was the name. With this PR they get the first line of the docstring for the component, plus a link to the full docs on our website.
This required adding a new (generated) reflection API.
Best reviewed commit-by-commit.
Related
CommonMarkViewer
adds empty veritcal space around it lampsitter/egui_commonmark#54Later PR
ArchetypeFieldInfo
into thereflection
module #6616Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.