Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for different data per timeline on Events and Timelines doc page #6912

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 16, 2024

What

Preview: https://landing-7a6fnura2-rerun.vercel.app/docs/concepts/timelines#reset-active-timeline--differing-data-per-timeline

After answering with this example on Discord, I noticed we haven't documented this ability anywhere. Added a three language snippet + a little bit of text to the Events and Timelines doc page.

Tested examples locally using pixi run python .\docs\snippets\compare_snippet_output.py concepts/different_data_per_timeline.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation include in changelog labels Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Deployed docs

Commit Link
73cface https://landing-503jqzj43-rerun.vercel.app/docs

@Wumpf Wumpf marked this pull request as draft July 16, 2024 13:26
@Wumpf
Copy link
Member Author

Wumpf commented Jul 16, 2024

drafted: this didn't actually run the snippet because of an incorrect setting in snippets.toml
and now I get strange crashes I have to investigate

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition 👍🏻

@Wumpf Wumpf changed the base branch from main to andreas/fix-reset-time-cpp July 16, 2024 13:45
@Wumpf Wumpf marked this pull request as ready for review July 16, 2024 13:45
@Wumpf Wumpf force-pushed the andreas/different-data-per-timeline-example branch from c6f852a to 5b094b2 Compare July 16, 2024 13:45
@Wumpf
Copy link
Member Author

Wumpf commented Jul 16, 2024

@Wumpf Wumpf added the do-not-merge Do not merge this PR label Jul 16, 2024
Base automatically changed from andreas/fix-reset-time-cpp to main July 16, 2024 14:48
An error occurred while trying to automatically change base from andreas/fix-reset-time-cpp to main July 16, 2024 14:48
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jul 16, 2024
@Wumpf Wumpf force-pushed the andreas/different-data-per-timeline-example branch from 5b094b2 to 73cface Compare July 16, 2024 14:51
@Wumpf Wumpf merged commit ea08cb1 into main Jul 16, 2024
40 checks passed
@Wumpf Wumpf deleted the andreas/different-data-per-timeline-example branch July 16, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants