Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting time destroying recording stream #6914

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 16, 2024

What

rerun::RecordingStream::reset_time accidentally destroyed the recording stream, causing it to fail/assert on any subsequent use, making the reset_time method unusable.

  • test to catch this

From the looks of it the method never worked to begin with.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog labels Jul 16, 2024
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@Wumpf Wumpf merged commit fea1904 into main Jul 16, 2024
39 checks passed
@Wumpf Wumpf deleted the andreas/fix-reset-time-cpp branch July 16, 2024 14:48
@teh-cmc teh-cmc changed the title [C++] Fix resetting time destroying recording stream Fix resetting time destroying recording stream Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants