Add send_columns examples for images, fix rust send_columns handling of listarrays
#7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itself contains a list array
Deployed docs
|
Wumpf
added
🦀 Rust API
Wumpf
force-pushed
the
andreas/more-send_columns-snippets
branch
from
46c8a1f to
1508207
Compare
emilk
approved these changes
Aug 14, 2024
| @@ -172,6 +172,11 @@ quick_start = [ # These examples don't have exactly the same implementation. | |||
| "py", | |||
| "rust", | |||
| ] | |||
| "archetypes/image_send_columns" = [ # This mixes `log` and `send_columns`. Since `log` is suspect to delays by the batcher, this test gets flaky. | |||
There was a problem hiding this comment.
I wonder if this could be fixed by tuning the batcher parameters… but probably it's not possible since it is running on a separate thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
send_columnssnippets for image, demonstrating to send several images at once efficientlysend_columnsno longer assumes that an encounteredListArrayis already the list array for the columnsend_columnscall for any component batch that's internally a list arrayUnfortunately, the snippet isn't fully deterministic and can't be compared cross language since the due to the batcher on
logcalls, log may arrive before or aftersend_columnsScreen.Recording.2024-08-14.at.11.03.12.mov
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.