Fix handling unnormalized axis for (Pose)RotationAxisAngle #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
changed the title
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
approved these changes
Dec 6, 2024
| if instance.world_from_mesh.matrix3.determinant() != 0.0 { | ||
| instance.world_from_mesh.matrix3.inverse().transpose() | ||
| } else { | ||
| glam::Mat3A::ZERO |
There was a problem hiding this comment.
Just to be sure, you meant it to be zero and not identity?
There was a problem hiding this comment.
yes. zero. Which is the most likely reason the determinant was zero to begin with 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as dodging associated debug-assertions for