Make Pinhole archetype in Rust eager serialized
#8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty methods to them
1 task
Wumpf
commented
Jan 23, 2025
| // TODO(andreas): Give this another pass and think about how we can remove this. | ||
| // Being disconnected from the blueprint & fallbacks makes this a weird snowflake with unexpected behavior. | ||
| // Also, figure out how this might actually relate to the transform cache. | ||
| pub fn query_pinhole_and_view_coordinates_from_store_without_blueprint( |
There was a problem hiding this comment.
this is essentially what query_pinhole_legacy used to do. But with an EVEN scarier name!
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
1 task
teh-cmc
pushed a commit
that referenced
this pull request
Jan 24, 2025
### Related * sister PR to.. * #8789 * #8785 * #8793 * missed piece of #7245 ### What Ports the Tensor archetype in rust to the new eager serialized interface. Unfortunately this meant I had to remove some direct access methods of the underlying tensor data. Curiously, this didn't affect any of our test/snippet/example code. While doing so I also fixed some wording issues in the (very similar) C++ implementation of `with_dim_names`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Box/AssetVideo/ViewCoordinates/Asset3Deager serialized in Rust #8785Image&Mesh3Darchetypes in Rust eager serialized #8793What
Deprecates a bunch of methods on
Pinhole, all of them still functional though through ad-hoc deserialization utilities.In the Viewer (concrete,
re_spatial_view) we don't use any of that and have now a new purpose-built type - I considered using the generated (attr.rust.archetype_native) type, but a custom built made a lot more sense for untangling the mess of adhoc queries we have around Pinhole. It might not look like it but the aspiration here was to not change how things work by much while having things better decoupled & cleaner.Bonus: the odd resolution oracle we already used is now visible on the pinhole visualizers's ui