Make rust Tensor archetype eager serialized
#8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
force-pushed
the
andreas/rust/eager-tensor
branch
from
782a7bf to
99e5f1d
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12950962529 |
teh-cmc
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Pinholearchetype in Rust eager serialized #8789Box/AssetVideo/ViewCoordinates/Asset3Deager serialized in Rust #8785Image&Mesh3Darchetypes in Rust eager serialized #8793What
Ports the Tensor archetype in rust to the new eager serialized interface.
Unfortunately this meant I had to remove some direct access methods of the underlying tensor data. Curiously, this didn't affect any of our test/snippet/example code.
While doing so I also fixed some wording issues in the (very similar) C++ implementation of
with_dim_names