Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-End tests for cancellation #228

Closed
Tracked by #978
slinkydeveloper opened this issue Nov 29, 2023 · 0 comments · Fixed by #236
Closed
Tracked by #978

End-to-End tests for cancellation #228

slinkydeveloper opened this issue Nov 29, 2023 · 0 comments · Fixed by #236
Assignees
@tillrohrmann

Comments

@slinkydeveloper
Copy link
Collaborator

slinkydeveloper commented Nov 29, 2023 •
edited by tillrohrmann
Loading

Making sure that canceling actually cancels the leaves and stops the parents.
@slinkydeveloper slinkydeveloper mentioned this issue Nov 29, 2023
Closed
@slinkydeveloper slinkydeveloper transferred this issue from restatedev/restate Nov 29, 2023
@tillrohrmann tillrohrmann mentioned this issue Dec 12, 2023
Closed
@tillrohrmann tillrohrmann self-assigned this Dec 15, 2023
tillrohrmann added a commit to tillrohrmann/e2e that referenced this issue Dec 18, 2023
@tillrohrmann
Add tests for cancellation
107022d 
This commit adds new e2e tests which ensure that cancellation works.
The following call chains are canceled:

* CancelTestService/StartTest --> BlockingService/Block --> BlockingSerivce/Block (inboxed call since BlockingService is singleton)
* CancelTestService/StartTest --> BlockingService/Block --> uncompleted awakeable
* CancelTestService/StartTest --> BlockingService/Block --> very long sleep

This fixes restatedev#228.
@tillrohrmann tillrohrmann mentioned this issue Dec 18, 2023
Merged
tillrohrmann added a commit to tillrohrmann/e2e that referenced this issue Dec 18, 2023
@tillrohrmann
Add tests for cancellation
462e0f0 
This commit adds new e2e tests which ensure that cancellation works.
The following call chains are canceled:

* CancelTestService/StartTest --> BlockingService/Block --> BlockingSerivce/Block (inboxed call since BlockingService is singleton)
* CancelTestService/StartTest --> BlockingService/Block --> uncompleted awakeable
* CancelTestService/StartTest --> BlockingService/Block --> very long sleep

This fixes restatedev#228.
tillrohrmann added a commit to tillrohrmann/e2e that referenced this issue Dec 18, 2023
@tillrohrmann
Add tests for cancellation
abdabfe 
This commit adds new e2e tests which ensure that cancellation works.
The following call chains are canceled:

* CancelTestService/StartTest --> BlockingService/Block --> BlockingSerivce/Block (inboxed call since BlockingService is singleton)
* CancelTestService/StartTest --> BlockingService/Block --> uncompleted awakeable
* CancelTestService/StartTest --> BlockingService/Block --> very long sleep

This fixes restatedev#228.
@tillrohrmann tillrohrmann mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for cancellation tillrohrmann/e2e
2 participants
@tillrohrmann @slinkydeveloper