Add tests for cancellation #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/228
branch
from
107022d to
462e0f0
Compare
Comment on lines
108
to
110
| // The termination signal might arrive before the blocking call to the cancel singleton was | ||
| // made, | ||
| // so we need to retry. |
There was a problem hiding this comment.
You can add a sync point with AwakeableHolder to CancelTestService as well.
There was a problem hiding this comment.
This wouldn't work for example when sleeping in the BlockingService. Will keep it as is.
tillrohrmann
force-pushed
the
issues/228
branch
from
462e0f0 to
0ff6312
Compare
|
Thanks for the review @slinkydeveloper. I've addressed your comments. PTAL. |
slinkydeveloper
approved these changes
Dec 19, 2023
This commit adds new e2e tests which ensure that cancellation works. The following call chains are canceled: * CancelTestService/StartTest --> BlockingService/Block --> BlockingSerivce/Block (inboxed call since BlockingService is singleton) * CancelTestService/StartTest --> BlockingService/Block --> uncompleted awakeable * CancelTestService/StartTest --> BlockingService/Block --> very long sleep This fixes restatedev#228.
tillrohrmann
force-pushed
the
issues/228
branch
from
0ff6312 to
58e590b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new e2e tests which ensure that cancellation works.
The following call chains are canceled:
This fixes #228.
For these e2e tests to work, we need to merge the following PRs first: