Upgrade test #167
Merged
Upgrade test #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
issues/restate_504
branch
4 times, most recently
from
02c48de to
98872c6
Compare
slinkydeveloper
force-pushed
the
issues/restate_504
branch
2 times, most recently
from
1eb5b61 to
c22fdb6
Compare
slinkydeveloper
force-pushed
the
issues/restate_504
branch
from
c22fdb6 to
f227fa9
Compare
tillrohrmann
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. +1 for merging after the required runtime PRs are merged.
test-utils/src/main/kotlin/dev/restate/e2e/utils/RestateDeployer.kt
Outdated
Show resolved
Hide resolved
...ces/java-services/src/main/java/dev/restate/e2e/services/upgradetest/UpgradeTestService.java
Outdated
Show resolved
Hide resolved
Comment on lines
+38
to
+39
| UpgradeTestServiceGrpc.SERVICE_NAME, | ||
| AwakeableHolderServiceGrpc.SERVICE_NAME, |
There was a problem hiding this comment.
I am wondering whether we shouldn't implement the services for the general tests with the typescript SDK if possible. That way we don't further cement our dependency on the Java SDK.
There was a problem hiding this comment.
Fair enough. Do you think should I go and re implement this test in TS or is this comment more something for future tests?
There was a problem hiding this comment.
Let's try to do it for new tests from now on, I'd say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix restatedev/restate#504