Record the endpoint id used when invoking a service, and restore it when replaying. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. +1 for merging after resolving my minor comments.
| } | ||
|
|
||
| pub(super) fn chosen_endpoint_to_notify(&mut self) -> Option<EndpointId> { | ||
| debug_assert!(matches!( |
| } => { | ||
| metadata.journal_metadata.endpoint_id = Some(endpoint_id); | ||
| state_storage | ||
| .store_invocation_status(&service_id, InvocationStatus::Invoked(metadata)) |
There was a problem hiding this comment.
Maybe add a comment why InvocationStatus::Invoked can be assumed here.
There was a problem hiding this comment.
Added, check now
slinkydeveloper
force-pushed
the
issues/503_second_attempt
branch
from
9a95b6a to
1b52615
Compare
Notify through invoker effects the chosen endpoint for an invocation.
slinkydeveloper
force-pushed
the
issues/503_second_attempt
branch
from
055053a to
70188f3
Compare
|
Tested with restatedev/e2e#167 and it works 🤩 |
tillrohrmann
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks for updating this PR @slinkydeveloper. LGTM. +1 for merging after resolving my only comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #570, Fix #503