Remove EndpointMetadata.delivery_options.retry_policy
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2023
slinkydeveloper
force-pushed
the
issues/569
branch
from
283c2f5 to
ea835a2
Compare
tillrohrmann
approved these changes
Jul 7, 2023
| @@ -791,7 +791,7 @@ where | |||
| partition: PartitionLeaderEpoch, | |||
| service_invocation_id: ServiceInvocationId, | |||
| journal: InvokeInputJournal, | |||
| state_machine_factory: impl FnOnce(RetryPolicy) -> InvocationStateMachine, | |||
| mut ism: InvocationStateMachine, | |||
There was a problem hiding this comment.
I am really bad with abbreviations. I'd say either you establish this abbreviation or we'll name it invocation_state_machine.
There was a problem hiding this comment.
This abbreviation is already used all around the codebase of the invoker, and the reason i named it this way here is to be consistent.
There was a problem hiding this comment.
Fair enough. In the future I would suggest to spell things out since we should optimize for reading and not for writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #569, based on #559. Needs restatedev/e2e#165