Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-hit moves damage pokemon using silk-trap #3312

Closed
marinepez opened this issue Sep 14, 2023 · 0 comments · Fixed by #3321
Closed

Multi-hit moves damage pokemon using silk-trap #3312

marinepez opened this issue Sep 14, 2023 · 0 comments · Fixed by #3321
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet

Comments

@marinepez
Copy link

Description

When using a multi-hit move against a pokemon using silk-trap, the first attack is protected, but subsequent attacks deal damage. The speed-lowering effect happens for every hit.

Version

1.5.3 (Default)

Upcoming Version

No response

Discord contact info

MarinePez
@marinepez marinepez added bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet labels Sep 14, 2023
@AsparagusEduardo AsparagusEduardo mentioned this issue Sep 21, 2023
Merged
AsparagusEduardo added a commit that referenced this issue Sep 26, 2023
@DizzyEggg @AsparagusEduardo
Fix protect recoil issue and add tests for protect (#3321)
e0e49a9 
* fix protect recoil issue and add tests for protect

* test for #3312 and baneful bunker fix

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* more recoil moves for protect test

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* rename spiky shield test

---------

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Pawkkie pushed a commit to Pawkkie/pokeemerald-expansion that referenced this issue Sep 27, 2023
@DizzyEggg @AsparagusEduardo @Pawkkie
Fix protect recoil issue and add tests for protect (rh-hideout#3321)
de3640a 
* fix protect recoil issue and add tests for protect

* test for rh-hideout#3312 and baneful bunker fix

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* more recoil moves for protect test

* Update test/battle/move_effect/protect.c

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>

* rename spiky shield test

---------

Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix protect recoil issue and add tests for protect DizzyEggg/pokeemerald
1 participant
@marinepez