Fix protect recoil issue and add tests for protect #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for the reviewer: also check #3312 |
|
The answer was: yes, it also fixed #3312. BUT good thing I wrote a test for all protect moves, because baneful bunker needed the same fix as the other two. Which is now fixed too |
AsparagusEduardo
requested changes
Sep 22, 2023
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
|
I removed the comment to the issue's github number, this should be ready to merge now. |
|
@AsparagusEduardo Should be ready to merge 👀 |
AsparagusEduardo
approved these changes
Sep 26, 2023
Merged
Pawkkie
pushed a commit
to Pawkkie/pokeemerald-expansion
that referenced
this pull request
Sep 27, 2023
* fix protect recoil issue and add tests for protect * test for rh-hideout#3312 and baneful bunker fix * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * more recoil moves for protect test * Update test/battle/move_effect/protect.c Co-authored-by: Eduardo Quezada D'Ottone <[email protected]> * rename spiky shield test --------- Co-authored-by: Eduardo Quezada D'Ottone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3304
Fixes #3312
Adds tests for all protect moves.