Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up remaining Castform hack stuff #3063

Merged
merged 13 commits into from
Jun 30, 2023
Merged

Cleaned up remaining Castform hack stuff #3063

merged 13 commits into from
Jun 30, 2023

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

Title.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo changed the base branch from master to upcoming June 19, 2023 13:07
DizzyEggg
DizzyEggg requested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@DizzyEggg DizzyEggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Cherrim doesn't transform in sunny weather at all
  2. Castform has a broken palette
    pokeemerald_01

@AsparagusEduardo
Copy link
Collaborator Author

  1. Castform has a broken palette

It seems a different PR broke this, because I'm working on an unrelated PR and Castform's palette is also broken there, so it must be an upcoming thing.
imagen

@DizzyEggg
Copy link
Collaborator

  1. Castform has a broken palette

It seems a different PR broke this, because I'm working on an unrelated PR and Castform's palette is also broken there, so it must be an upcoming thing. imagen

Yeah, can confirm it's also broken on upcoming. I would say it's in scope of this PR to fix it :D

@AsparagusEduardo
Copy link
Collaborator Author

Yeah, can confirm it's also broken on upcoming. I would say it's in scope of this PR to fix it :D

Alright

@AsparagusEduardo
Copy link
Collaborator Author

  1. Cherrim doesn't transform in sunny weather at all

Can't reproduce.
mGBA_Q2Ve9pBBIv

@DizzyEggg
Copy link
Collaborator

  1. Cherrim doesn't transform in sunny weather at all

Can't reproduce. mGBA_Q2Ve9pBBIv

You're right, it works, my bad

@AsparagusEduardo
Copy link
Collaborator Author

Fixed Castform palettes. (Shiny weather palettes are the same regular ones)
imagen imagen imagen imagen imagen

@SonikkuA-DatH
Copy link

Castform starting with Gen 8's HOME has true shiny colors for the forms. I'll DM you the needed pals for that

@AsparagusEduardo
Copy link
Collaborator Author

Castform starting with Gen 8's HOME has true shiny colors for the forms. I'll DM you the needed pals for that

Please make a separate PR for it. I'm done with this one tbh.

@DizzyEggg DizzyEggg merged commit 81e59ac into rh-hideout:upcoming Jun 30, 2023
@DizzyEggg DizzyEggg mentioned this pull request Jun 30, 2023
Closed
@AsparagusEduardo AsparagusEduardo mentioned this pull request Jul 1, 2023
Merged
@AsparagusEduardo AsparagusEduardo deleted the RHH/pr/cleanup/Castform branch July 2, 2023 19:06
@AsparagusEduardo AsparagusEduardo mentioned this pull request Jul 2, 2023
Closed
@AsparagusEduardo AsparagusEduardo mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DizzyEggg DizzyEggg DizzyEggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsparagusEduardo @DizzyEggg @SonikkuA-DatH