Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shadows in viewer #3094

Merged
merged 2 commits into from
Jul 2, 2023
Merged

Conversation

gruxor
Copy link

@gruxor gruxor commented Jun 30, 2023

Description

  • Shadows only break because they're accessing data that doesn't exist until state 2, so added a check
  • Two castform-related functions in this file were throwing warnings on modern due to lack of arg type signatures, so lumped a quick fix in with this PR

Issue(s) that this PR fixes

Fixes #3091

Discord contact info

crater.

@AsparagusEduardo
Copy link
Collaborator

The castform functions are being deleted in #3063, so no point in updating those

@gruxor gruxor changed the title Fixed shadows in viewer + minor arg signature fix Fixed shadows in viewer Jul 1, 2023
@gruxor
Copy link
Author

gruxor commented Jul 2, 2023

Should be good now. Also figured I'd mention, you can probably just throw this onto master since the bug exists there as well, as you guessed. Pretty tiny fix, shouldn't disturb anything.

@AsparagusEduardo AsparagusEduardo merged commit 68ce97c into rh-hideout:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pokémon sprite menu doesn't refresh shadows when switching shininess
2 participants