Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Openjdk 2588] install tar in runtime images (ubi8) #428

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Dec 18, 2023

@jmtd jmtd requested a review from sefroberg December 18, 2023 16:18
@jmtd
Copy link
Member Author

jmtd commented Dec 18, 2023

I need to investigate the GHA failures for builder images

@jerboaa
Copy link
Contributor

jerboaa commented Dec 18, 2023

I need to investigate the GHA failures for builder images

Missing equivalent of: https://github.com/jboss-container-images/openjdk/pull/418 ?

@jmtd
Copy link
Member Author

jmtd commented Jan 8, 2024

Missing equivalent of: #418 ?

Ah yes. I've started that now in #432.

@jmtd jmtd force-pushed the OPENJDK-2588-tar branch from 953549e to ddf5024 Compare January 8, 2024 15:55
@jmtd
Copy link
Member Author

jmtd commented Jan 10, 2024

  • 11 runtime image, 8 runtime image, 17 s2i all have one test failure: the label version check. The fix for that is merged in the main ubi8 branch but this PR predates that (and doesn't touch those labels)
  • 8 also fails "Ensure that run-env.sh placed in the JAVA_APP_DIR is sourced in the run script before launching java" which is a quarkus test so 8 shouldn't be tagged for it; it is not in the main ubi8 branch any more

`oc rsync` requires either `tar` or `rsync` to be present in the
container images. `oc cp` requires `tar`. Install `tar` in the
runtime images so that both `oc` commands function. This results
in a negligible (+0.6MiB) increase in container size.

<https://issues.redhat.com/browse/OPENJDK-2588>

`tar` and `rsync` are already present in the builder images.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd force-pushed the OPENJDK-2588-tar branch from ddf5024 to 025c2b1 Compare January 10, 2024 13:42
@jmtd jmtd requested a review from jerboaa January 10, 2024 14:22
@jmtd jmtd merged commit 140a10e into rh-openjdk:ubi8 Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants