refresh GHA runners for UBI8 tests #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These shadow the values from our base image which are otherwise misleading, and result in the test "Check that common labels are correctly set" passing. Signed-off-by: Jonathan Dowland <[email protected]>
Move the majority of the workflow configuration into a template workflow, defined in image-workflow-template.yml, and call it from the workflows for each image. Pass in "image" as a workflow input. Signed-off-by: Jonathan Dowland <[email protected]>
Signed-off-by: Jonathan Dowland <[email protected]>
This is a hail-mary change: we are experiencing problems with GHA runs timing out (behave tests taking up to five hours to run). We were running on a not-current GHA runner version, and I think the old runners get fewer resources than the newer ones. Signed-off-by: Jonathan Dowland <[email protected]>
A successful run of the jobs should take on the order of 20-30 minutes, so this timeout gives about twice that for headroom. This should cause stuck jobs to fail faster than the default of 6 hours. Signed-off-by: Jonathan Dowland <[email protected]>
s2i misbehaves if registry credentials are present: tries and fails to query image metadata from docker.io before each build, etc. See: openshift/source-to-image#1134 Signed-off-by: Jonathan Dowland <[email protected]>
The jmtd fork of behave-test-steps has its v1 branch matching this PR: cekit/behave-test-steps#50 This adds a multiprocess watchdog around invoking `docker.APIClient.exec_inspect`, which will abort the current step if that call has not returned within 30 seconds. This means a lock-up during a step will cause that test to fail and not the whole test run. Signed-off-by: Jonathan Dowland <[email protected]>
This test is based on Quarkus which does not support JDK8. Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
changed the title
|
@sefroberg most of this PR is stuff specific to running the Behave tests on GitHub actions, but there are some label changes from https://issues.redhat.com/browse/OPENJDK-2438 in there too, FYI. They're included because the tests for them were included already but failing. |
jerboaa
reviewed
Jan 8, 2024
These consistently fail on GHA which requires further analysis to resolve. In the meantime we need a functioning CI. Signed-off-by: Jonathan Dowland <[email protected]>
Presently failing on GHA for all of JDKs 11,16,21; passes locally. We will investigate why in a separate issue, meanwhile disable so we can run the remaining tests. Signed-off-by: Jonathan Dowland <[email protected]>
|
The current round of test-run failures above are all caused by transient GitHub issues (error 500 when cloning various repositories). I'm kicking off re-runs. |
jerboaa
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to be the UBI8 equivalent of #418
It rolls up a fix for https://issues.redhat.com/browse/OPENJDK-2438 (commit references the UBI9 variant of that bug, OPENJDK-2414)