Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug report link text #15

Merged
merged 2 commits into from
Jan 21, 2018
Merged

Update bug report link text #15

merged 2 commits into from
Jan 21, 2018

Conversation

will-stone
Copy link
Contributor

@will-stone will-stone commented Dec 14, 2017

"found bug?" > "Report an issue"

@will-stone
Copy link
Contributor Author

I feel like I should have given more detail on why I'm proposing this small change. Firstly, I feel that "found bug?" doesn't feel grammatically correct. Secondly, links don't tend to be questions, but actions. And thirdly, "bug" is rather colloquial and most organisations (GitHub etc.) call them "issues". This also infers people can report more than just bugs, such as feature requests. I feel like this small change will improve the window's air of professionalism.

@jhnferraris
Copy link
Contributor

@will-stone Any idea on how we can do the bug text programmatically? Say

"bug-text": "Some text" || <default from this library>

@will-stone
Copy link
Contributor Author

@jhnferraris I'm not the repo owner. That sort of i18n would be up to @rhysd

@rhysd
Copy link
Owner

rhysd commented Jan 21, 2018

Thank you for suggesting that. It would be better.

I thought 'found bug?' is just a short-hand of 'did you found a bug?', but I'm not sure that it sounds correct (I'm not a native English speaker/writer). And as you said, only bug should not be reported, other type of issue should probably be reported.

@rhysd rhysd merged commit 766d332 into rhysd:master Jan 21, 2018
@will-stone will-stone deleted the patch-1 branch January 21, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants