Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bug text to allow dynamic modification of message #17

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

jhnferraris
Copy link
Contributor

The rationale behind here is to allow clients to set their own bug text

@jhnferraris jhnferraris changed the title Added bug text to allow dynamic modification Added bug text to allow dynamic modification of message Jan 17, 2018
@rhysd
Copy link
Owner

rhysd commented Jan 21, 2018

#15 was merged. Do you still need this PR to be merged?

@jhnferraris
Copy link
Contributor Author

Yes. It would be better for apps to have their own message.

App A: “experiencing an issue? Submit a report”
App B: “If you’re experiencing issues, you can email us at.”

Thanks!

@rhysd
Copy link
Owner

rhysd commented Jan 22, 2018

ok, please resolve conflict. Please note that when #14 is fixed, this feature may have some breaking change (in the case, of course I bump up major version of this package).

@jhnferraris
Copy link
Contributor Author

@rhysd How will I resolve this? I do not have write access.

screenshot from 2018-01-22 17-19-21

@jhnferraris
Copy link
Contributor Author

Figured how to do it. Here's the updated PR

@rhysd
Copy link
Owner

rhysd commented Jan 23, 2018

Thanks.

@rhysd rhysd merged commit 4eacdd9 into rhysd:master Jan 23, 2018
@jhnferraris
Copy link
Contributor Author

@rhysd Is this already published?

@rhysd
Copy link
Owner

rhysd commented Jan 25, 2018

Not yet. I'm now on biz trip to SF and I don't have a machine to publish an npm package. So let me publish a new version after backing to Japan. New version should come at end of this week. Sorry for making you wait.

@jhnferraris
Copy link
Contributor Author

@rhysd No problem. Enjoy your trip bro.

@rhysd
Copy link
Owner

rhysd commented Jan 29, 2018

@jhnferraris @will-stone I published v1.9.0 including customizable issue report link text (with default text is update)

@rhysd
Copy link
Owner

rhysd commented Jan 29, 2018

@jhnferraris Please note that I renamed bug_text property to bug_link_text because it's more obvious.

@jhnferraris
Copy link
Contributor Author

jhnferraris commented Jan 29, 2018

@rhysd Thanks!

@will-stone
Copy link
Contributor

@rhysd nice one. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants