-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bug text to allow dynamic modification of message #17
Conversation
#15 was merged. Do you still need this PR to be merged? |
Yes. It would be better for apps to have their own message. App A: “experiencing an issue? Submit a report” Thanks! |
ok, please resolve conflict. Please note that when #14 is fixed, this feature may have some breaking change (in the case, of course I bump up major version of this package). |
@rhysd How will I resolve this? I do not have write access. |
Figured how to do it. Here's the updated PR |
Thanks. |
@rhysd Is this already published? |
Not yet. I'm now on biz trip to SF and I don't have a machine to publish an npm package. So let me publish a new version after backing to Japan. New version should come at end of this week. Sorry for making you wait. |
@rhysd No problem. Enjoy your trip bro. |
@jhnferraris @will-stone I published v1.9.0 including customizable issue report link text (with default text is update) |
@jhnferraris Please note that I renamed |
@rhysd Thanks! |
@rhysd nice one. Thanks! |
The rationale behind here is to allow clients to set their own bug text