Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): Use simple structures #8870

Merged
merged 14 commits into from
Mar 30, 2023
Merged

refactor(plan_node): Use simple structures #8870

merged 14 commits into from
Mar 30, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Mar 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

I have removed the need of some stupid intermediate structures that exist only for historical reasons.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 changed the title chore(plan_node): Use simple structures refactor(plan_node): Use simple structures Mar 29, 2023
st1page
st1page previously approved these changes Mar 30, 2023
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st1page st1page dismissed their stale review March 30, 2023 07:41

need to change the plan node id back

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #8870 (5040a07) into main (1f14219) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8870      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.01%     
==========================================
  Files        1181     1181              
  Lines      195790   195771      -19     
==========================================
- Hits       138644   138613      -31     
- Misses      57146    57158      +12     
Flag Coverage Δ
rust 70.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/optimizer/plan_node/batch_hash_join.rs 91.06% <100.00%> (-0.25%) ⬇️
...c/frontend/src/optimizer/plan_node/generic/join.rs 93.88% <100.00%> (+0.15%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_join.rs 90.22% <100.00%> (-0.05%) ⬇️
...ntend/src/optimizer/plan_node/stream_delta_join.rs 96.38% <100.00%> (-0.11%) ⬇️
...ontend/src/optimizer/plan_node/stream_hash_join.rs 92.03% <100.00%> (+0.17%) ⬆️
...ontend/src/optimizer/rule/index_delta_join_rule.rs 91.91% <100.00%> (+0.08%) ⬆️
src/frontend/src/scheduler/distributed/query.rs 69.15% <100.00%> (-0.43%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ice1000 ice1000 enabled auto-merge March 30, 2023 17:59
@ice1000 ice1000 added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 620ab91 Mar 30, 2023
@ice1000 ice1000 deleted the tesla/stream branch March 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants