Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): Avoid abusing PlanBase::new_logical_with_core #9288

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Apr 20, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176, #9209.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 force-pushed the tesla/sla branch 2 times, most recently from 63be347 to 11b3881 Compare April 20, 2023 04:23
@ice1000
Copy link
Contributor Author

ice1000 commented Apr 20, 2023

Test passed~ Yay!

@ice1000 ice1000 added this pull request to the merge queue Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #9288 (24ca1ce) into main (2334e07) will decrease coverage by 0.02%.
The diff coverage is 92.72%.

@@            Coverage Diff             @@
##             main    #9288      +/-   ##
==========================================
- Coverage   70.82%   70.81%   -0.02%     
==========================================
  Files        1219     1219              
  Lines      202579   202512      -67     
==========================================
- Hits       143484   143401      -83     
- Misses      59095    59111      +16     
Flag Coverage Δ
rust 70.81% <92.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../frontend/src/optimizer/plan_node/stream_expand.rs 0.00% <0.00%> (ø)
...src/optimizer/plan_node/stream_local_simple_agg.rs 93.54% <93.33%> (-0.82%) ⬇️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 84.39% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 95.73% <100.00%> (-0.54%) ⬇️
src/frontend/src/optimizer/plan_node/plan_base.rs 98.02% <100.00%> (+0.23%) ⬆️
...ntend/src/optimizer/plan_node/stream_delta_join.rs 96.17% <100.00%> (-0.21%) ⬇️
...rontend/src/optimizer/plan_node/stream_exchange.rs 91.35% <100.00%> (-0.21%) ⬇️
.../frontend/src/optimizer/plan_node/stream_filter.rs 97.50% <100.00%> (-0.33%) ⬇️
...rc/optimizer/plan_node/stream_global_simple_agg.rs 90.80% <100.00%> (-1.12%) ⬇️
...rontend/src/optimizer/plan_node/stream_hash_agg.rs 98.19% <100.00%> (-0.18%) ⬇️
... and 3 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 8052dec Apr 20, 2023
@ice1000 ice1000 deleted the tesla/sla branch April 20, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants