update ios workflows to runt tests on push / pr to master #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivian
reviewed
Jun 28, 2021
.github/workflows/tests.yml
Outdated
Comment on lines
4
to
7
| push: | ||
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
I think just push is enough. It should not allow the PR to be merged if the checks fail there.
There was a problem hiding this comment.
yeah i think so too. will deal with that once we've filled out the doc for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #82
run tests on push/pr ... we can refine it once we figured out exactly when we want to run these
fails when tests fail 👇
