Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ios workflows to runt tests on push / pr to master #83

Merged
merged 2 commits into from
Jun 28, 2021
Merged

update ios workflows to runt tests on push / pr to master #83

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65bf9e7
update ios workflows to runt tests on push / pr to master
mjtalbot Jun 28, 2021
5c8406d
push is enough
mjtalbot Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Run Rive tests

on:
push:
pull_request:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just push is enough. It should not allow the PR to be merged if the checks fail there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think so too. will deal with that once we've filled out the doc for that


jobs:
run_tests:
name: Run Rive tests
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v2
with:
token: ${{ secrets.RIVE_REPO_PAT }}
submodules: recursive
- name: Testing iOS app
run: sh ./scripts/test.sh
7 changes: 7 additions & 0 deletions scripts/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
set -eo pipefail

# test RiveRuntime on a simulator
xcodebuild -workspace Rive.xcworkspace \
-scheme RiveRuntime \
-destination platform=iOS\ Simulator,name=iPhone\ 11 \
clean test | xcpretty