fix SASL that differed from original aiokafka #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By when can we have release with this change? This is blocking our upgrade to v1.9.2 |
|
Same here, this is blocking our update, which is heavily needed due to the memory leaks on version 1.7 and lower. Breaking SASL authentication is a major change for every production system, how come this has not been caught in tests and isn't released already ? |
|
I confirm that this PR fixes the issue - can it please be merged!? |
|
Sorry for the late response, wasn't aware of this. We need someone to triage issues :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the SASL started to differ from aiokafka and cause error at start
AssertionError: yield from wasn't used with futureThis patch restore the current master of aiokafka, which i've tested on both aiokafka and faust.