Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SASL that differed from original aiokafka #18

Merged
merged 1 commit into from
Feb 25, 2020
Merged

fix SASL that differed from original aiokafka #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion aiokafka/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,8 @@ def __init__(self, host, port, *, loop, client_id='aiokafka',
if loop.get_debug():
self._source_traceback = traceback.extract_stack(sys._getframe(1))

# Warn and try to close. We can close synchroniously, so will attempt
# that
def __del__(self, _warnings=warnings):
if self.connected():
if PY_36:
Expand Down Expand Up @@ -458,6 +460,7 @@ def _create_reader_task(self):
functools.partial(self._on_read_task_error, self_ref))
return read_task

@classmethod
async def _read(cls, self_ref):
# XXX: I know that it become a bit more ugly once cyclic references
# were removed, but it's needed to allow connections to properly
Expand Down Expand Up @@ -520,7 +523,7 @@ def _next_correlation_id(self):

class BaseSaslAuthenticator:

async def step(self, payload):
def step(self, payload):
return self._loop.run_in_executor(None, self._step, payload)

def _step(self, payload):
Expand Down