Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the mrie encoder. Increase version to 1.34.2 #82

Merged
merged 2 commits into from
May 11, 2023

Conversation

valegagge
Copy link
Member

In this PR I added the mrie encoder type.
I updated the version to 1.34.2.

Even if this change doesn't affect the firmware, I'm going to compile all FWs and open a PR.

This PR is related with this one of icub-main.

@pattacini
Copy link
Member

This PR is related with this robotology/icub-main#869 of icub-main

Can we merge this PR so that I can proceed with enabling the CI on icub-main?

cc @marcoaccame

@marcoaccame marcoaccame changed the title Added the mrie encoder. Increase verion to 1.34.2 Added the mrie encoder. Increase version to 1.34.2 May 11, 2023
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are OK.

Also, they do not affect the code of the boards, so no changes in icub-firmware or new binaries in icub-firmware-build are required.

@marcoaccame marcoaccame merged commit 2960d6c into robotology:devel May 11, 2023
MSECode pushed a commit to MSECode/icub-firmware-shared that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants