Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the mrie encoder name in the parser of motion control service. #869

Merged
merged 3 commits into from
May 11, 2023
Merged

Added the mrie encoder name in the parser of motion control service. #869

merged 3 commits into from
May 11, 2023

Conversation

valegagge
Copy link
Member

@valegagge valegagge commented May 9, 2023 •
edited
Loading

Now we can use the mrie name in the configuration file.
This encoder is used for the new joints.

I already tested this PR on the medium joint setup and it works together.

This code needs the updated icub-firmware-shared at version 1.34.2.
I'll open a new PR for it.

@pattacini pattacini marked this pull request as draft May 9, 2023 10:34
@valegagge valegagge mentioned this pull request May 9, 2023
Merged
pattacini
pattacini requested changes May 9, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the PR in draft1 as the CI will fail most likely since we need to be aligned with icub-firmware-shared.

Footnotes

  1. For a draft PR we don't run CI. ↩

conf/iCubFindDependencies.cmake Outdated Show resolved Hide resolved
pattacini
pattacini approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning on the CI

@pattacini pattacini marked this pull request as ready for review May 11, 2023 09:26
@pattacini pattacini merged commit 5ebdca5 into robotology:devel May 11, 2023
@valegagge valegagge deleted the feature/mrieParser branch June 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valegagge @pattacini