Fix 'double free or corruption' error on yarpdev --list

[martinaxgloria]

This PR should fix #840.

Together with @sgiraz, we found out that the double free or corruption error that was retrieved when running yarpdev --list may occur in eth::EthBoards class. In particular, it seems that the destructor of this class is responsible for destroying some members of this class, but then another function is trying to free memory that was already freed.

@marcoaccame what do you think about it? Could you please have a look?

[pattacini]

Detailed analysis reported in:

• malloc_consolidate(): invalid chunk size Aborted (core dumped) error when running yarpdev --list #840 (comment)

[traversaro]

Are this variables used anywhere? If they are not used, perhaps an easier fix is just to remove them?

[traversaro]

Are this variables used anywhere? If they are not used, perhaps an easier fix is just to remove them?

I may be wrong, but it seems that defaultnames is not used.

[martinaxgloria]

Are this variables used anywhere? If they are not used, perhaps an easier fix is just to remove them?

Hi @traversaro,
they seem not to be used anywhere

[martinaxgloria]

We could keep this PR open waiting for @marcoaccame feedback (I think he's the author of this code) and then we decide how to fix this issue

[marcoaccame]

Hi @martinaxgloria, your change compiles and solves the problem. So it is fine by me.

Only comment (to myself, as I wrote this code): variable defaultnames is not used so it may be removed. But for now, let's go for the quick fix.

[pattacini]

Fine with me