-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigation file-based configuration of the buffer manager #39
Comments
I found a very nice c++ library for parsing JSON files https://github.com/nlohmann/json In particular, it can be imported also as a single header(see https://github.com/nlohmann/json/tree/develop/single_include/nlohmann) and in particular this feature is awesome. We may implement the |
Good idea! I would however implement it in separate function/headers, so that we can easily add more conversions in the future, for example from/to yarp::os::Property as well, and permit to users to provide their own conversions, as adding more functions is easy, while adding methods to an existing class is impossible outside of the project. |
Regarding the use of single header, we can also support using like that (especially if we want to support 18.04 that has an old version: https://repology.org/project/nlohmann-json/versions), but I would have at least an option to find it externally via |
…truct We have to move these in different header It fixes #39
In #65 we implemented the configuration from json, and that library is really easy to use! We have to investigate how to handle the case in which the user forgot a parameter |
It would be nice to have keywords like |
…truct We have to move these in different header It fixes #39
…truct We have to move these in different header It fixes #39
I like that library as well, has a modern approach to C++.
The header only version is handy, except when you start using all over your
coffee it slows down compilation time.
Also uses a lot of exceptions whenever anything is not perfect, which
personally I don't like so much.
Also, the boost::ptree is a good alternative to parse json file
Il mar 9 feb 2021, 12:30 Nicolò Genesio (二コゲネ) <[email protected]>
ha scritto:
… Closed #39
<#39> via
#65 <#65>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA67OXBBFH3ST3VI3LVII33S6EMGTANCNFSM4WI4HBIQ>
.
|
Me neither, when the file misses some attribute is not clear what is missing or what it is wrong |
No description provided.
The text was updated successfully, but these errors were encountered: