TelemetryDeviceDumper: make the BM configurable from xml file #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #100
Before proceeding with #101, I would settle which parameters are configurable from the file and which ones are mandatory.
In this implementation, the configuration of the BM from JSON will overwrite the parameter-by-parameters configuration.
n_samples
is mandatory, as it is mandatory alsosave_period
ifsave_periodically
is set to true.At the end it checks, if both
save_periodically
andauto_save
are set to false the configuration will fail and the device will close.An issue that I see is that the configuration with the JSON and the configuration parameter-by-parameter are different.
experiment_name
isfile_name
in the JSON configuration(this probably has to be fixed) and in the JSON configuration ALL the parameters are mandatory for #39 (comment) (also this has to be investigated)THIS HAS TO BE TESTED ON THE ROBOT.
cc @S-Dafarra