Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to snake_case builtins #305

Merged
merged 13 commits into from
Jan 10, 2025
Merged

Upgrade to snake_case builtins #305

merged 13 commits into from
Jan 10, 2025

Conversation

lukewilliamboswell
Copy link
Collaborator

Paired with the breaking change roc-lang/roc#7463

@lukewilliamboswell lukewilliamboswell changed the title [WIP] Upgrade to snake_case builtins Upgrade to snake_case builtins Jan 7, 2025
@lukewilliamboswell lukewilliamboswell marked this pull request as ready for review January 7, 2025 22:26
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to roc-json in lukewilliamboswell/roc-json#42

flake.nix Outdated Show resolved Hide resolved
smores56
smores56 previously approved these changes Jan 9, 2025
ci/rust_http_server/src/main.rs Outdated Show resolved Hide resolved
platform/File.roc Outdated Show resolved Hide resolved
platform/Sqlite.roc Outdated Show resolved Hide resolved
platform/Sqlite.roc Outdated Show resolved Hide resolved
smores56
smores56 previously approved these changes Jan 9, 2025
@lukewilliamboswell
Copy link
Collaborator Author

@Anton-4 -- this should be ready to land/release. Needs a testing or pre-release from Roc to pass CI for the native machines.

smores56
smores56 previously approved these changes Jan 9, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 10, 2025

Needs a testing or pre-release from Roc to pass CI for the native machines.

Relying on nix may be best for this transition period because it's pinned to a commit

@Anton-4 Anton-4 merged commit c89c762 into main Jan 10, 2025
3 checks passed
@Anton-4 Anton-4 deleted the snake_case_builtins branch January 10, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants