Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move builtins to snake_case #7463

Merged
merged 25 commits into from
Jan 8, 2025
Merged

Conversation

smores56
Copy link
Collaborator

@smores56 smores56 commented Jan 4, 2025

Now that we have automatic camelCase -> snake_case conversion and parentheses-based function call support, we can move our builtins to snake_case and parens. This started as an attempt to auto-convert camelCase idents to snake_case ones by translating all idents in our canonicalization phase to snake_case, but it led to some tricky issues surrounding FFI. This has become a monolithic change of all roc idents I could find in code and tests from camelCase to snake_case.

Once all of the tests are passing with this PR, we should prepare PRs for basic-cli and basic-webserver and then just shoot all three of these snake_case changes out of a cannon simultaneously.

These are WIP:
basic-cli PR
basic-webserver PR

@smores56
Copy link
Collaborator Author

smores56 commented Jan 4, 2025

When I remove the auto-case conversion in the string interner, there is still infinite hanging in the build script, so there must be something else that I forgot to update in the compiler

@smores56 smores56 changed the title Move builtins to snake_case with auto-case conversion Move builtins to snake_case Jan 5, 2025
@smores56 smores56 changed the title Move builtins to snake_case DO NOT MERGE Move builtins to snake_case Jan 5, 2025
@smores56 smores56 marked this pull request as ready for review January 5, 2025 15:30
@smores56
Copy link
Collaborator Author

smores56 commented Jan 7, 2025

We depend on basic-ssg for our website, and that is using old builtins. I'm working on updating it, this is blocked on getting a basic-ssg pre-release with snake_case builtins.

@smores56 smores56 changed the title DO NOT MERGE Move builtins to snake_case Move builtins to snake_case Jan 7, 2025
@smores56 smores56 enabled auto-merge January 8, 2025 10:48
@smores56 smores56 merged commit 96fc573 into roc-lang:main Jan 8, 2025
18 checks passed
@smores56 smores56 deleted the auto-snake-case branch January 8, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants