-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move builtins to snake_case #7463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I remove the auto-case conversion in the string interner, there is still infinite hanging in the build script, so there must be something else that I forgot to update in the compiler |
smores56
changed the title
Move builtins to snake_case with auto-case conversion
Move builtins to snake_case
Jan 5, 2025
This was referenced Jan 5, 2025
smores56
changed the title
Move builtins to snake_case
DO NOT MERGE Move builtins to snake_case
Jan 5, 2025
We depend on basic-ssg for our website, and that is using old builtins. I'm working on updating it, this is blocked on getting a |
smores56
changed the title
DO NOT MERGE Move builtins to snake_case
Move builtins to snake_case
Jan 7, 2025
gamebox
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have automatic
camelCase -> snake_case
conversion and parentheses-based function call support, we can move our builtins tosnake_case
and parens. This started as an attempt to auto-convertcamelCase
idents tosnake_case
ones by translating all idents in our canonicalization phase tosnake_case
, but it led to some tricky issues surrounding FFI. This has become a monolithic change of all roc idents I could find in code and tests fromcamelCase
tosnake_case
.Once all of the tests are passing with this PR, we should prepare PRs for
basic-cli
andbasic-webserver
and then just shoot all three of thesesnake_case
changes out of a cannon simultaneously.These are WIP:
basic-cli PR
basic-webserver PR