Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade examples to snake_case builtins and PNC #228

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

lukewilliamboswell
Copy link
Collaborator

Paired with the breaking change roc-lang/roc#7463

smores56
smores56 previously approved these changes Jan 10, 2025
@@ -15,22 +15,24 @@ Model : {}
# generate css by running `tailwindcss`,...
# In this case we don't have anything to initialize, so it is just `Task.ok {}`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this Task thing? I've never heard of it.

@lukewilliamboswell
Copy link
Collaborator Author

lukewilliamboswell commented Jan 10, 2025

Status: all of the examples updated with the exception of the platforms (DotNet, Go), and the ImportPackageFromModule example.

To update ImportPackageFromModule we will need to first upgrade roc-lang/unicode.

Edit : we need to do a pass over all the README's... I definitely missed a bunch of things in there.

@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 10, 2025

Status: all of the examples updated with the exception of the platforms (DotNet, Go), and the ImportPackageFromModule example.
To update ImportPackageFromModule we will need to first upgrade roc-lang/unicode.
Edit : we need to do a pass over all the README's... I definitely missed a bunch of things in there.

I can take this

@Anton-4 Anton-4 self-assigned this Jan 10, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 11, 2025

All done :)
I did both updates and improvements of the example code and README.

@Anton-4 Anton-4 removed their assignment Jan 11, 2025
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 11, 2025

To update ImportPackageFromModule we will need to first upgrade roc-lang/unicode.

This still needs to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants