implement an optional post-YAML cache of loaded sections #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optimizations introduced by 2694f14 changed the semantic of the normalized configurations - namely by allowing typelib objects to be stored, to speedup both loading and application of the configuration. Fix the tests that got broken by this.
This was motivated by the need to load huge config files, that define
splines. I'd rather not write a separate file that needs to be loaded
in C++. Luckily, it also speeds up even loading small files significantly
Using the cache on a file with two sections and a single boolean
property makes it 1.4x faster. A file with multiple huge 2000
elements numerical arrays (300k lines of YAML) is sped up by 8.5
times, reducing to a respectable 300ms from a 2s delay.
Benchmark results follow:
Small file:
~~~
Warming up --------------------------------------
no cache 457.000 i/100ms
cache 660.000 i/100ms
Calculating -------------------------------------
no cache 4.630k (± 0.6%) i/s - 23.307k in 5.035237s
cache 6.671k (± 0.7%) i/s - 33.660k in 5.048211s
with 95.0% confidence
Comparison:
cache: 6670.8 i/s
no cache: 4630.2 i/s - 1.44x (± 0.01) slower
with 95.0% confidence
~~~
Big file:
~~~
Warming up --------------------------------------
no cache 1.000 i/100ms
cache 1.000 i/100ms
Calculating -------------------------------------
no cache 0.361 (± 0.8%) i/s - 2.000 in 5.537452s
cache 3.091 (± 1.3%) i/s - 16.000 in 5.179861s
with 95.0% confidence
Comparison:
cache: 3.1 i/s
no cache: 0.4 i/s - 8.56x (± 0.15) slower
with 95.0% confidence
~~~
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See e354392 for details and benchmarks.