Speedup plugin loading #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
force-pushed
the
speedup_plugin_loading
branch
2 times, most recently
from
339200c to
04369c8
Compare
doudou
force-pushed
the
speedup_plugin_loading
branch
from
04369c8 to
edc0d8f
Compare
doudou
force-pushed
the
speedup_plugin_loading
branch
from
edc0d8f to
e87d5a2
Compare
… find the plugin libraries
… in Orocos.load_typekit anymore This actually was harming load times, as we would unconditionally load the pkg-config object while load_typekit_plugins would do it only if the typekit was not already loaded.
doudou
force-pushed
the
speedup_plugin_loading
branch
from
e87d5a2 to
4698035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on orocos-toolchain/utilrb#30 and orocos-toolchain/orogen#77
Instead of doing full pkg-config file resolution, we only extract the information that is really needed. It fixes the performance hit caused by the application of orocos-toolchain/orogen#77.