Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provisional Django 2.2 LTS update #2625

Closed
2 tasks done
phillxnet opened this issue Jul 22, 2023 · 3 comments
Closed
2 tasks done

Provisional Django 2.2 LTS update #2625

phillxnet opened this issue Jul 22, 2023 · 3 comments
Assignees
@phillxnet
Milestone
Django update wit...

Comments

@phillxnet
Copy link
Member

phillxnet commented Jul 22, 2023 •
edited
Loading

Update our Django dependency, as per associated milestone: it is generally recommend to only update Django from one LTS to the next: 2.2 LTS is our next-in-line and covered by this issue.

[EDIT]
Some in-development discoveries: Not directly relevant but we clean as we go given 2.2 is only a stepping stone for us:

  • RemovedInDjango31Warning: TestCase.multi_db is deprecated.
  • RemovedInDjango31Warning: CachedStaticFilesStorage is deprecated in favor of ManifestStaticFilesStorage. Replaced by dedicated issue: Update django-pipeline to latest #2689
This was referenced Aug 2, 2023
Closed
Closed
@phillxnet phillxnet mentioned this issue Aug 10, 2023
Merged
@phillxnet phillxnet self-assigned this Oct 9, 2023
@phillxnet
Copy link
Member Author

Initially we have:

Django-1.11.29 to Django-2.2.28
pytz-2023.3 to pytz-2023.3.post1
urllib3-1.26.16 to  urllib3-1.26.17

with some minor/additional dependency changes.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 9, 2023
@phillxnet
Provisional Django 2.2 LTS update rockstor#2625
e793664 
Update our Django dependency. It is generally recommended
to only update Django from one LTS to the next: 2.2 LTS
is our next-in-line.

Includes a prior overlooked migration intended for this
Django update. See:GitHub rockstor#2666 rockstor#2667
@phillxnet phillxnet mentioned this issue Oct 10, 2023
Closed
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 10, 2023
@phillxnet
Replace deprecated multi_db with databases property rockstor#2625
83ecc49 
- RemovedInDjango31Warning: TestCase.multi_db is deprecated.
@phillxnet
Copy link
Member Author

phillxnet commented Oct 10, 2023 •
edited
Loading

Our remaining "RemovedInDjango31Warning: CachedStaticFilesStorage is deprecated in favor of ManifestStaticFilesStorage" appears to be related to our currently pinned version django-pipeline, limited at the time to 1.7 due to our older Django. See: #2646 by @FroggyFlox :

It is thus proposed that we temporarily upgrade to django-pipeline 1.7 now, before further upgrading during our move to Django 2.2 LTS, for which support was added in jazzband/django-pipeline#693 (thanks to @phillxnet for finding that last one).

And we have the following in their changelog for 2.0.1:
https://github.com/jazzband/django-pipeline/blob/master/HISTORY.rst#201

  • Add subclass of ManifestStaticFilesStorage. Thank to @jhpinson
  • Change the documentation to use PipelineManifestStorage in configuration instead of PipelineCachedStorage now deprecated.
  • ...

https://github.com/jazzband/django-pipeline/blob/master/HISTORY.rst#207

https://pypi.org/project/django-pipeline/2.0.9/
is the last to specifically mention Py3.6 however no specific dropping of Py3.6 has yet been found: still looking!

Current is 2.1.0: https://pypi.org/project/django-pipeline/

NOTE: This comment's concern has now been split out into the following:
Issue: #2689
Milestone: https://github.com/rockstor/rockstor-core/milestone/24

@phillxnet phillxnet mentioned this issue Oct 10, 2023
Closed
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Oct 10, 2023
@phillxnet
Provisional Django 2.2 LTS update rockstor#2625
de00cb4 
Update our Django dependency. It is generally recommended
to only update Django from one LTS to the next: 2.2 LTS
is our next-in-line.

## Includes
- A prior overlooked migration intended to prepare for this
Django update. See:GitHub rockstor#2666 rockstor#2667
- Replace deprecated multi_db with databases 'property':
"RemovedInDjango31Warning: TestCase.multi_db is deprecated."
Which ended up breaking one of our unit tests. And so was
included in this update.

N.B. there remains some Django update warnings but these are
to be addressed in future dedicated issues/commits.
@phillxnet phillxnet mentioned this issue Oct 10, 2023
Merged
phillxnet added a commit that referenced this issue Oct 10, 2023
@phillxnet
Merge pull request #2690 from phillxnet/2625-Provisional-Django-2.2-L…
fe74fe2 
…TS-update

Provisional Django 2.2 LTS update #2625
@FroggyFlox
Copy link
Member

Closing as fixed by #2690.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
Django update within current major de...
Development

No branches or pull requests
2 participants
@phillxnet @FroggyFlox