Establish on_delete for ForeignKey re Django update #2645

phillxnet · 2023-08-08T16:33:11Z

In part preparation for "Provisional Django 2.2 LTS update #2625" we need to update our models and migrations re:

RemovedInDjango20Warning: on_delete will be a required arg for ForeignKey in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete

RemovedInDjango20Warning: on_delete will be a required arg for OneToOneField in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete

/opt/rockstor/.venv/bin/python -Wd /opt/rockstor/.venv/bin/django-admin.py runserver lbuildvm.lan:80 
/opt/rockstor/src/rockstor/storageadmin/models/snapshot.py:25: RemovedInDjango20Warning: on_delete will be a required arg for ForeignKey in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete
  share = models.ForeignKey("Share")  # Resolve circular dependency
/opt/rockstor/src/rockstor/storageadmin/models/share.py:31: RemovedInDjango20Warning: on_delete will be a required arg for ForeignKey in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete
  pool = models.ForeignKey(Pool)
/opt/rockstor/src/rockstor/storageadmin/models/nfs_export.py:25: RemovedInDjango20Warning: on_delete will be a required arg for ForeignKey in Django 2.0. Set it to models.CASCADE on models and in existing migrations if you want to maintain the current default behavior. See https://docs.djangoproject.com/en/1.11/ref/models/fields/#django.db.models.ForeignKey.on_delete
  export_group = models.ForeignKey(NFSExportGroup)

Many more reports like above though-out most of our models.

[EDIT] The following checklist was sed prepared from the full version of the above after all duplicate warnings (and leading src path) were first removed via a regular editor:

sed ':a; /\:$/N; s/\:\n/ /; ta' models-dupliicate-warnings-removed.txt > on_delete_model_list.txt
sed -i 's/^/- \[ \] /' on_delete_model_list.txt

Performing system checks...

System check identified no issues (0 silenced).

The text was updated successfully, but these errors were encountered:

phillxnet · 2023-08-09T17:51:01Z

Just have to sort out the appropriate migration file for all these changes and some back-log we have in the migration area and can then present a pull request against this issue.

phillxnet · 2023-08-10T10:46:56Z

Notes on the creation of the associated new migration files:

lbuildvm:/opt/rockstor # cd /opt/rockstor
lbuildvm:/opt/rockstor # export DJANGO_SETTINGS_MODULE=settings
lbuildvm:/opt/rockstor # poetry run django-admin makemigrations storageadmin
Migrations for 'storageadmin':
  src/rockstor/storageadmin/migrations/0017_auto_20230810_1141.py
    - Alter field hostname on appliance
    - Alter field config_backup on configbackup
    - Alter field editable on nfsexportgroup
    - Alter field mount_security on nfsexportgroup
    - Alter field syncable on nfsexportgroup
    - Alter field description on plugin
    - Alter field display_name on plugin
    - Alter field status on poolbalance
    - Alter field rate on poolscrub
    - Alter field status on poolscrub
    - Alter field owner on posixacls
    - Alter field perms on posixacls
    - Alter field browsable on sambashare
    - Alter field comment on sambashare
    - Alter field guest_ok on sambashare
    - Alter field read_only on sambashare
    - Alter field editable on sftp
    - Alter field group on share
    - Alter field owner on share
    - Alter field perms on share
    - Alter field pqgroup on share
    - Alter field assessment on smartidentity
    - Alter field ata_version on smartidentity
    - Alter field capacity on smartidentity
    - Alter field device_model on smartidentity
    - Alter field enabled on smartidentity
    - Alter field firmware_version on smartidentity
    - Alter field in_smartdb on smartidentity
    - Alter field model_family on smartidentity
    - Alter field rotation_rate on smartidentity
    - Alter field sata_version on smartidentity
    - Alter field scanned_on on smartidentity
    - Alter field sector_size on smartidentity
    - Alter field serial_number on smartidentity
    - Alter field supported on smartidentity
    - Alter field version on smartidentity
    - Alter field world_wide_name on smartidentity
    - Alter field real_name on snapshot
    - Alter field snap_type on snapshot
    - Alter field case_type on supportcase
    - Alter field status on supportcase
    - Alter field username on user
lbuildvm:/opt/rockstor # poetry run django-admin makemigrations smart_manager
Migrations for 'smart_manager':
  src/rockstor/smart_manager/migrations/0003_auto_20230810_1143.py
    - Alter field state on sprobe
    - Alter field task_type on taskdefinition

phillxnet · 2023-08-10T11:01:07Z

The new migration files do not contain the new on_delete. It is currently assumed this is as a result of having back-ported the on_delete additions to our existing migration files. However there does exist entries in the migration files stating an AlterField for each affected model.
See: https://code.djangoproject.com/ticket/28677
And: https://docs.djangoproject.com/en/dev/releases/1.9/#foreignkey-and-onetoonefield-on-delete-argument

phillxnet · 2023-08-10T13:15:05Z

Test migrations of within an initrock prepared database set look to apply as expected:

lbuildvm:~ # cd /opt/rockstor
lbuildvm:/opt/rockstor # export DJANGO_SETTINGS_MODULE=settings
lbuildvm:/opt/rockstor # poetry run django-admin migrate storageadmin
Operations to perform:
  Apply all migrations: storageadmin
Running migrations:
  Applying storageadmin.0017_auto_20230810_1141... OK
lbuildvm:/opt/rockstor # poetry run django-admin migrate --database=smart_manager smart_manager
Operations to perform:
  Apply all migrations: smart_manager
Running migrations:
  Applying smart_manager.0003_auto_20230810_1143... OK

Adds now required on_delete argument to all ForeignKey and OneToOneField definitions: in both model definitions and all prior migration files. The resulting migration files for storageadmin (default) and smart_manager were created via: - poetry run django-admin makemigrations storageadmin - poetry run django-admin makemigrations smart_manager

…ForeignKey-re-Django-update Establish on_delete for ForeignKey re Django update #2645

phillxnet · 2023-08-14T16:30:52Z

Closing as:
Fixed by #2648

phillxnet self-assigned this Aug 8, 2023

phillxnet mentioned this issue Aug 10, 2023

Establish on_delete for ForeignKey re Django update #2645 #2648

Merged

phillxnet added this to the Django update within current major dependency constraints milestone Aug 10, 2023

phillxnet added a commit that referenced this issue Aug 14, 2023

Merge pull request #2648 from phillxnet/2645-Establish-on_delete-for-…

f6d51fa

…ForeignKey-re-Django-update Establish on_delete for ForeignKey re Django update #2645

phillxnet closed this as completed Aug 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Establish on_delete for ForeignKey re Django update #2645

Establish on_delete for ForeignKey re Django update #2645

phillxnet commented Aug 8, 2023 •

edited

Loading

phillxnet commented Aug 9, 2023

phillxnet commented Aug 10, 2023

phillxnet commented Aug 10, 2023 •

edited

Loading

phillxnet commented Aug 10, 2023

phillxnet commented Aug 14, 2023

Establish on_delete for ForeignKey re Django update #2645

Establish on_delete for ForeignKey re Django update #2645

Comments

phillxnet commented Aug 8, 2023 • edited Loading

phillxnet commented Aug 9, 2023

phillxnet commented Aug 10, 2023

phillxnet commented Aug 10, 2023 • edited Loading

phillxnet commented Aug 10, 2023

phillxnet commented Aug 14, 2023

phillxnet commented Aug 8, 2023 •

edited

Loading

phillxnet commented Aug 10, 2023 •

edited

Loading