Add e2e test for default flood trigger layers #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannisvisser
requested changes
Dec 16, 2024
| test( | ||
| qase( | ||
| 37, | ||
| '[Trigger] Map layer: "Flood extent" and "Exposed population" should be active by default', |
There was a problem hiding this comment.
What is the exact purpose of this test. I often get mixed up by filenames vs test descriptions here vs full test cases in Qase. Is in this case the test just about the layers being present in the legend? And with legend do you mean the lower-left thing or the lower-right thing?
Either way, I think it makes sense to test all together. So test (1) are the layers in the layer overview (lower-right), (2) are they in the legend (lower-left), and (3) are they in the map? I'm not clear on if this is happening now either in this test or in multiple tests.
|
|
||
| await map.mapComponentIsVisible(); | ||
| await map.isLegendOpen({ legendOpen: true }); | ||
| await map.assertLegendElementIsVisible({ |
There was a problem hiding this comment.
now only legend is tested. test also layer overview and map (proxy via radio-btn being active)
Piotrk39
deleted the
feat.add-e2e-test-for-default-flood-trigger-layers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds test for default triggered layers Floods
Checklist before requesting a review