Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for default flood trigger layers #1832

Merged
merged 5 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
}
@if (isRadioButton(layer.group)) {
<ion-icon
data-testid="matrix-radio-button"
[name]="
layer.active
? 'radio-button-on-outline'
Expand Down
36 changes: 36 additions & 0 deletions tests/e2e/Pages/MapComponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ class MapComponent extends DashboardPage {
readonly layerMenu: Locator;
readonly adminBoundry: Locator;
readonly layerCheckbox: Locator;
readonly layerRadioButton: Locator;
readonly legendHeader: Locator;
readonly layerMenuToggle: Locator;
readonly redCrossMarker: Locator;
readonly gloFASMarker: Locator;
readonly alerThresholdLines: Locator;
readonly closeButtonIcon: Locator;
readonly layerInfoContent: Locator;
readonly ibfAggregatePane: Locator;

constructor(page: Page) {
super(page);
Expand All @@ -45,6 +47,7 @@ class MapComponent extends DashboardPage {
this.layerMenu = this.page.getByTestId('layer-menu');
this.adminBoundry = this.page.locator('.leaflet-interactive');
this.layerCheckbox = this.page.getByTestId('matrix-checkbox');
this.layerRadioButton = this.page.getByTestId('matrix-radio-button');
this.legendHeader = this.page.getByTestId('map-legend-header');
this.layerMenuToggle = this.page.getByTestId('layer-menu-toggle-button');
this.redCrossMarker = this.page.getByAltText('Red Cross branches');
Expand All @@ -54,6 +57,9 @@ class MapComponent extends DashboardPage {
);
this.closeButtonIcon = this.page.getByTestId('close-matrix-icon');
this.layerInfoContent = this.page.getByTestId('layer-info-content');
this.ibfAggregatePane = this.page.locator(
'.leaflet-pane.leaflet-ibf-aggregate-pane',
);
}

async mapComponentIsVisible() {
Expand Down Expand Up @@ -160,6 +166,25 @@ class MapComponent extends DashboardPage {
}
}

async verifyLayerRadioButtonCheckedByName({
layerName,
}: {
layerName: string;
}) {
const getLayerRow = this.page
.getByTestId('matrix-layer-name')
.filter({ hasText: layerName });
const layerCheckbox = getLayerRow.locator(this.layerRadioButton);

// In case of checbox being checked the name attribute should be "checkbox"
const nameAttribute = await layerCheckbox.getAttribute('name');
const isChecked = nameAttribute === 'radio-button-on-outline';

if (!isChecked) {
throw new Error(`Radio button for layer ${layerName} is not checked`);
}
}

async clickInfoButtonByName({ layerName }: { layerName: string }) {
await this.page
.locator(`ion-item`)
Expand Down Expand Up @@ -356,5 +381,16 @@ class MapComponent extends DashboardPage {
expect(await glofasMarker.count()).toBe(0);
}
}

// This method checks that when radio button is checked then the layer is visible in leaflet-ibf-aggregate-pane
// Only one radio button can be checked at a time
// It valdates the functionality not data displayed
async validateAggregatePaneIsNotEmpty() {
const aggregatePaneContent = this.ibfAggregatePane.locator(
'.leaflet-interactive',
);
const aggregatePaneContentCount = await aggregatePaneContent.count();
expect(aggregatePaneContentCount).toBeGreaterThan(0);
}
}
export default MapComponent;
63 changes: 63 additions & 0 deletions tests/e2e/tests/Map/DefaultLegendLayersInTriggeredFlood.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
import { test } from '@playwright/test';
import DashboardPage from 'Pages/DashboardPage';
import MapComponent from 'Pages/MapComponent';
import UserStateComponent from 'Pages/UserStateComponent';
import { qase } from 'playwright-qase-reporter';
import { TriggerDataSet } from 'testData/testData.enum';

import { FloodsScenario } from '../../../../services/API-service/src/scripts/enum/mock-scenario.enum';
import {
getAccessToken,
mockFloods,
resetDB,
} from '../../helpers/utility.helper';
import LoginPage from '../../Pages/LoginPage';

let accessToken: string;

test.beforeEach(async ({ page }) => {
// Login
const loginPage = new LoginPage(page);
accessToken = await getAccessToken();
await resetDB(accessToken);

// We should maybe create one mock for all different disaster types for now we can just use floods
await mockFloods(
FloodsScenario.Trigger,
TriggerDataSet.CountryCode,
accessToken,
);

await page.goto('/');
await loginPage.login(TriggerDataSet.UserMail, TriggerDataSet.UserPassword);
});
// https://app.qase.io/project/IBF?previewMode=side&suite=3&tab=&case=37
test(
qase(
37,
'[Trigger] Map layer: "Flood extent" and "Exposed population" should be active by default',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the exact purpose of this test. I often get mixed up by filenames vs test descriptions here vs full test cases in Qase. Is in this case the test just about the layers being present in the legend? And with legend do you mean the lower-left thing or the lower-right thing?

Either way, I think it makes sense to test all together. So test (1) are the layers in the layer overview (lower-right), (2) are they in the legend (lower-left), and (3) are they in the map? I'm not clear on if this is happening now either in this test or in multiple tests.

),
async ({ page }) => {
const dashboard = new DashboardPage(page);
const userState = new UserStateComponent(page);
const map = new MapComponent(page);

// Navigate to disaster type the data was mocked for
await dashboard.navigateToFloodDisasterType();
// Assertions
await userState.headerComponentIsVisible({
countryName: TriggerDataSet.CountryName,
});
// Wait for the page to load
await dashboard.waitForLoaderToDisappear();

await map.mapComponentIsVisible();
await map.isLegendOpen({ legendOpen: true });
await map.assertLegendElementIsVisible({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now only legend is tested. test also layer overview and map (proxy via radio-btn being active)

legendComponentName: 'Flood extent',
});
await map.assertLegendElementIsVisible({
legendComponentName: 'Exposed population',
});
},
);
69 changes: 69 additions & 0 deletions tests/e2e/tests/Map/ExposedPopulationVisibleInTrigger.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import { test } from '@playwright/test';
import DashboardPage from 'Pages/DashboardPage';
import MapComponent from 'Pages/MapComponent';
import UserStateComponent from 'Pages/UserStateComponent';
import { qase } from 'playwright-qase-reporter';
import { TriggerDataSet } from 'testData/testData.enum';

import { FloodsScenario } from '../../../../services/API-service/src/scripts/enum/mock-scenario.enum';
import {
getAccessToken,
mockFloods,
resetDB,
} from '../../helpers/utility.helper';
import LoginPage from '../../Pages/LoginPage';

let accessToken: string;

test.beforeEach(async ({ page }) => {
// Login
const loginPage = new LoginPage(page);
accessToken = await getAccessToken();
await resetDB(accessToken);

// We should maybe create one mock for all different disaster types for now we can just use floods
await mockFloods(
FloodsScenario.Trigger,
TriggerDataSet.CountryCode,
accessToken,
);

await page.goto('/');
await loginPage.login(TriggerDataSet.UserMail, TriggerDataSet.UserPassword);
});

test(
qase(
36,
Piotrk39 marked this conversation as resolved.
Show resolved Hide resolved
'[Trigger] Exposed population legend is visible when exposed population layer is active',
),
async ({ page }) => {
const dashboard = new DashboardPage(page);
const userState = new UserStateComponent(page);
const map = new MapComponent(page);

// Navigate to disaster type the data was mocked for
await dashboard.navigateToFloodDisasterType();
// Assertions
await userState.headerComponentIsVisible({
countryName: TriggerDataSet.CountryName,
});
// Wait for the page to load
await dashboard.waitForLoaderToDisappear();

await map.mapComponentIsVisible();
await map.isLegendOpen({ legendOpen: true });
await map.isLayerMenuOpen({ layerMenuOpen: false });
await map.clickLayerMenu();
await map.isLayerMenuOpen({ layerMenuOpen: true });
await map.verifyLayerRadioButtonCheckedByName({
layerName: 'Exposed population',
});
await map.assertLegendElementIsVisible({
legendComponentName: 'Exposed population',
});
// Exposed population layer should be visible by default in trigger mode
// Validate that the aggregate pane is not empty after the layer is checked and loaded
await map.validateAggregatePaneIsNotEmpty();
},
);
Loading